aokolnychyi commented on code in PR #40679: URL: https://github.com/apache/spark/pull/40679#discussion_r1159129904
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala: ########## @@ -32,19 +33,53 @@ import org.apache.spark.sql.types.StructType class DatabaseAlreadyExistsException(db: String) extends NamespaceAlreadyExistsException(Array(db)) +// any changes to this class should be backward compatible as it may be used by external connectors +class NamespaceAlreadyExistsException private( Review Comment: I tried to support all 3.3 constructors. It is actually tricky as it was a case class before. Therefore, there is no way to make it 100% compatible. I can add a custom companion object to make it act like the old case class. @gengliangwang, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
