gengliangwang commented on code in PR #40679: URL: https://github.com/apache/spark/pull/40679#discussion_r1159164691
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala: ########## @@ -32,19 +33,53 @@ import org.apache.spark.sql.types.StructType class DatabaseAlreadyExistsException(db: String) extends NamespaceAlreadyExistsException(Array(db)) +// any changes to this class should be backward compatible as it may be used by external connectors +class NamespaceAlreadyExistsException private( Review Comment: > It is actually tricky as it was a case class before I took a look at https://github.com/apache/spark/pull/37887/files and `NamespaceAlreadyExistsException` doesn't seem to be a case class. Anyway, I don't strong opinion. It's up to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
