Hisoka-X commented on code in PR #40684:
URL: https://github.com/apache/spark/pull/40684#discussion_r1160381245
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala:
##########
@@ -49,7 +49,7 @@ import org.apache.spark.util.Utils
object SparkConnectServerUtils {
// Server port
- private[connect] val port = ConnectCommon.CONNECT_GRPC_BINDING_PORT +
util.Random.nextInt(1000)
+ val port: Int = ConnectCommon.CONNECT_GRPC_BINDING_PORT +
util.Random.nextInt(1000)
Review Comment:
> You could use `private[spark] val port: Int` accessor?
Thanks for remind, I changed it.
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -69,6 +69,9 @@ class SparkSession private[sql] (
private[this] val allocator = new RootAllocator()
+ // a unique session ID for this session from client.
+ private[sql] lazy val sessionId: String = client.sessionId
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
