amaliujia commented on code in PR #40684: URL: https://github.com/apache/spark/pull/40684#discussion_r1160395678
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ########## @@ -69,6 +69,9 @@ class SparkSession private[sql] ( private[this] val allocator = new RootAllocator() + // a unique session ID for this session from client. + private[sql] def sessionId: String = client.sessionId Review Comment: Nit: this to be more accurate should be `user_id+session_id`. However because session_id itself is a random number thus `client.sessionId` should still be able to identify SparkSession uniquely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
