ryan-johnson-databricks commented on code in PR #40677:
URL: https://github.com/apache/spark/pull/40677#discussion_r1162753183
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala:
##########
@@ -165,6 +164,17 @@ trait FileFormat {
}
}
+ /**
+ * Create a file metadata struct column containing fields supported by the
given file format.
+ */
+ def createFileMetadataCol(): AttributeReference = {
+ // Strip out the fields' metadata to avoid exposing it to the user.
[[FileSourceStrategy]]
+ // avoids confusion by mapping back to [[metadataSchemaFields]].
Review Comment:
I personally find the brackets more readable (and my editor likes them
better than backticks as well).
Is there a rule against using them in normal comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
