ryan-johnson-databricks commented on code in PR #40677:
URL: https://github.com/apache/spark/pull/40677#discussion_r1162755460
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala:
##########
@@ -276,10 +275,16 @@ object FileFormat {
// the modificationTime from the file is in millisecond,
// while internally, the TimestampType `file_modification_time` is
stored in microsecond
row.update(i, fileModificationTime * 1000L)
- case ROW_INDEX =>
- // Do nothing. Only the metadata fields that have identical values
for each row of the
- // file are set by this function, while fields that have different
values (such as row
- // index) are set separately.
+ case other =>
+ // Other metadata columns use the file-provided value (if any). As a
courtesy, convert any
+ // normal strings to the required [[UTF8String]].
+ //
+ // TODO(frj): Do we need to potentially support value-producing
functions?
Review Comment:
Removing for now, because the TODO doesn't add any meaningful information.
If/when the need arises, it will be obvious enough that this code needs to
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
