rangadi commented on code in PR #40736:
URL: https://github.com/apache/spark/pull/40736#discussion_r1163105563
##########
python/pyspark/sql/connect/group.py:
##########
@@ -262,8 +264,44 @@ def applyInPandas(
applyInPandas.__doc__ = PySparkGroupedData.applyInPandas.__doc__
- def applyInPandasWithState(self, *args: Any, **kwargs: Any) -> None:
- raise NotImplementedError("applyInPandasWithState() is not
implemented.")
+ def applyInPandasWithState(
Review Comment:
Minor: Could you remove `assert state.get[0] == 1` in the code example in
the PR description? I think it is not required.
##########
python/pyspark/sql/connect/proto/types_pb2.pyi:
##########
@@ -48,13 +48,15 @@ else:
DESCRIPTOR: google.protobuf.descriptor.FileDescriptor
+@typing_extensions.final
Review Comment:
These changes might be due to difference in python code generator.
Cc: @HyukjinKwon (are we planning to generated these at build time to avoid
issues like this?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
