WweiL commented on code in PR #40736:
URL: https://github.com/apache/spark/pull/40736#discussion_r1163172520
##########
python/pyspark/sql/connect/group.py:
##########
@@ -262,8 +264,44 @@ def applyInPandas(
applyInPandas.__doc__ = PySparkGroupedData.applyInPandas.__doc__
- def applyInPandasWithState(self, *args: Any, **kwargs: Any) -> None:
- raise NotImplementedError("applyInPandasWithState() is not
implemented.")
+ def applyInPandasWithState(
+ self,
+ func: "PandasGroupedMapFunctionWithState",
+ outputStructType: Union[StructType, str],
Review Comment:
I see other part of the code use quoted types, i.e. `Union["StructType",
str]`. Maybe we should also do that for code consistency?
Also doing that seems to [help with forward
reference](https://stackoverflow.com/questions/46458470/should-you-put-quotes-around-type-annotations-in-python)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
