WweiL commented on PR #40736: URL: https://github.com/apache/spark/pull/40736#issuecomment-1503960956
Also I think we need to add unit test for this by reusing tests here https://github.com/apache/spark/pull/37894 You can follow [my PR](https://github.com/apache/spark/pull/40691/files#r1162341092) to 1. create a new mixin class that contains all test cases from the original one but don't extend `ReusedSQLTestCase`, and create a new class below with the original name and extend this mixin class and `ReusedSQLTestCase` 2. create a parity test class that extends this mixin class and `ReusedConnectTestCase` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
