HyukjinKwon commented on code in PR #40785:
URL: https://github.com/apache/spark/pull/40785#discussion_r1171967135
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -298,6 +306,15 @@ message StreamingQueryCommandResult {
// Logical and physical plans as string
string result = 1;
}
+
+ message ExceptionResult {
+ // Exception message as string
+ optional string exception_message = 1;
+ }
+
+ message AwaitTerminationResult {
+ optional bool terminated = 1;
Review Comment:
QQ; why is it `optional`? I thought it's always true or false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
