rangadi commented on code in PR #40785:
URL: https://github.com/apache/spark/pull/40785#discussion_r1172019473
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2255,6 +2255,23 @@ class SparkConnectPlanner(val session: SparkSession) {
.build()
respBuilder.setExplain(explain)
+ case StreamingQueryCommand.CommandCase.EXCEPTION =>
+ val result = query.exception
+ result.foreach(e =>
+ respBuilder.getExceptionBuilder
+ .setExceptionMessage(SparkConnectService.extractErrorMessage(e)))
+
+ case StreamingQueryCommand.CommandCase.AWAIT_TERMINATION =>
+ if (command.getAwaitTermination.hasTimeoutMs) {
+ val terminated =
query.awaitTermination(command.getAwaitTermination.getTimeoutMs)
+ respBuilder.getAwaitTerminationBuilder
+ .setTerminated(terminated)
+ } else {
+ query.awaitTermination()
Review Comment:
The client keep sending heart beat message to keep the RPC connection alive.
That said, we would still need to improve handling of this. E.g. it should
exit if client side disconnects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
