WweiL commented on code in PR #40785:
URL: https://github.com/apache/spark/pull/40785#discussion_r1171967844
##########
python/pyspark/sql/connect/streaming/query.py:
##########
@@ -66,11 +69,21 @@ def isActive(self) -> bool:
isActive.__doc__ = PySparkStreamingQuery.isActive.__doc__
- # TODO (SPARK-42960): Implement and uncomment the doc
def awaitTermination(self, timeout: Optional[int] = None) ->
Optional[bool]:
- raise NotImplementedError()
+ cmd = pb2.StreamingQueryCommand()
+ if timeout is not None:
+ if not isinstance(timeout, (int, float)) or timeout <= 0:
+ raise ValueError("timeout must be a positive integer or float.
Got %s" % timeout)
+ cmd.await_termination.timeout_ms = int(timeout * 1000)
+ terminated =
self._execute_streaming_query_cmd(cmd).await_termination.terminated
+ return terminated
+ else:
+ await_termination_cmd =
pb2.StreamingQueryCommand.AwaitTerminationCommand()
+ cmd.await_termination.CopyFrom(await_termination_cmd)
+ self._execute_streaming_query_cmd(cmd)
+ return None
Review Comment:
I remember I got local lint errors when removing this. I could check if it
still fails in github actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
