pengzhon-db commented on code in PR #41026: URL: https://github.com/apache/spark/pull/41026#discussion_r1192857264
########## connector/connect/common/src/main/protobuf/spark/connect/commands.proto: ########## @@ -209,6 +209,15 @@ message WriteStreamOperationStart { string path = 11; string table_name = 12; } + + optional Foreach foreach = 13; +} + +message Foreach { + // (Required) The encoded commands of the Python foreach function + bytes command = 1; Review Comment: Feels we can reuse PythonUDF, then you don't `transformPythonForeachFunction` on server, which is duplicate or existing one? ########## connector/connect/common/src/main/protobuf/spark/connect/commands.proto: ########## @@ -209,6 +209,15 @@ message WriteStreamOperationStart { string path = 11; string table_name = 12; } + + optional Foreach foreach = 13; +} + +message Foreach { + // (Required) The encoded commands of the Python foreach function + bytes command = 1; Review Comment: Feels we can reuse PythonUDF, then you don't `transformPythonForeachFunction` on server, which is duplicate of existing one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org