WweiL commented on code in PR #41026:
URL: https://github.com/apache/spark/pull/41026#discussion_r1194154060
##########
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala:
##########
@@ -455,6 +465,16 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
this
}
+ private[sql] def foreachConnect(writer: PythonForeachWriter):
DataStreamWriter[T] = {
Review Comment:
Yes actually this change is due to the change I added in scala foreach:
https://github.com/apache/spark/pull/41129/files#r1194152295
The writer will be a generic ForeachWriter[Any]. Here I put
PythonForeachWriter because at this stage it doesn't need to be generic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
