WweiL commented on code in PR #41026:
URL: https://github.com/apache/spark/pull/41026#discussion_r1194355729
##########
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala:
##########
@@ -532,7 +547,10 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
private var extraOptions = CaseInsensitiveMap[String](Map.empty)
- private var foreachWriter: ForeachWriter[T] = null
+ private var foreachWriter: ForeachWriter[Any] = null
+
+ private var foreachWriterEncoder: Either[ExpressionEncoder[Any], InternalRow
=> Any] =
+ Left(ds.exprEnc.asInstanceOf[ExpressionEncoder[Any]])
Review Comment:
@hvanhovell Hi Herman, can you signoff this change? It can be viewed
together with this PR for more context:
https://github.com/apache/spark/pull/41129/files#r1194152295
Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
