rangadi commented on code in PR #41026: URL: https://github.com/apache/spark/pull/41026#discussion_r1195715408
########## sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala: ########## @@ -354,7 +355,8 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) { query } else if (source == SOURCE_NAME_FOREACH) { assertNotPartitioned(SOURCE_NAME_FOREACH) - val sink = ForeachWriterTable[T](foreachWriter, ds.exprEnc) + val sink = ForeachWriterTable[Any](foreachWriter, + ds.exprEnc.asInstanceOf[ExpressionEncoder[Any]]) Review Comment: Is this casting necessary? What if we replace 'Any' with '_' for `foreachWriter`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org