viirya commented on code in PR #41599:
URL: https://github.com/apache/spark/pull/41599#discussion_r1231545554
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala:
##########
@@ -1188,6 +1188,8 @@ case class ScalaUDF(
private[this] val resultConverter = catalystConverter
+ private def functionName = udfName.map { uName => s"$uName in $funcCls"
}.getOrElse(funcCls)
Review Comment:
Sounds strange that the function is in class name? Maybe
```suggestion
private def functionName = udfName.map { uName => s"$uName ($funcCls)"
}.getOrElse(funcCls)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
