MaxGekk commented on code in PR #41599:
URL: https://github.com/apache/spark/pull/41599#discussion_r1235718913
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -207,12 +207,12 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase {
messageParameters = Map("typeName" -> (dataType + failure)))
}
- def failedExecuteUserDefinedFunctionError(funcCls: String, inputTypes:
String,
+ def failedExecuteUserDefinedFunctionError(functionName: String, inputTypes:
String,
outputType: String, e: Throwable): Throwable = {
new SparkException(
errorClass = "FAILED_EXECUTE_UDF",
messageParameters = Map(
- "functionName" -> funcCls,
+ "functionName" -> functionName,
Review Comment:
> The main purpose of toSQLId that I see is to remove a prefix of
__auto_generated_subquery_name in an attribute name and backticks between
period delimiters.
Main purpose of quoting is to highlight inlined (variable) elements in the
error message format. In particular, we mark SQL identifiers in error messages
by backticks.
Is `functionName` an identifier or not in this context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
