robreeves commented on code in PR #41599:
URL: https://github.com/apache/spark/pull/41599#discussion_r1235814851
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -207,12 +207,12 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase {
messageParameters = Map("typeName" -> (dataType + failure)))
}
- def failedExecuteUserDefinedFunctionError(funcCls: String, inputTypes:
String,
+ def failedExecuteUserDefinedFunctionError(functionName: String, inputTypes:
String,
outputType: String, e: Throwable): Throwable = {
new SparkException(
errorClass = "FAILED_EXECUTE_UDF",
messageParameters = Map(
- "functionName" -> funcCls,
+ "functionName" -> functionName,
Review Comment:
Yes `functionName` is acting as an identifier for a UDF here. My main
concern is for the hive UDF case the backticks around each part of the fully
qualified class name does not feel natural. I would prefer the backticks around
the entire name like `` `org.apache.foo.Bar` ``. This is subjective though so
I'm okay deferring to your preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
