mridulm commented on code in PR #41785:
URL: https://github.com/apache/spark/pull/41785#discussion_r1248434451
##########
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java:
##########
@@ -245,12 +245,13 @@ TransportClient createClient(InetSocketAddress address)
logger.debug("Creating new connection to {}", address);
Bootstrap bootstrap = new Bootstrap();
+ int connCreateTimeout = conf.connectionCreationTimeoutMs();
Review Comment:
I would have simply thrown an exception when `connCreateTimeout <= 0` - and
we can avoid the rest of the PR.
Will that not work ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
