yaooqinn commented on code in PR #41785:
URL: https://github.com/apache/spark/pull/41785#discussion_r1252471339
##########
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java:
##########
@@ -245,12 +245,13 @@ TransportClient createClient(InetSocketAddress address)
logger.debug("Creating new connection to {}", address);
Bootstrap bootstrap = new Bootstrap();
+ int connCreateTimeout = conf.connectionCreationTimeoutMs();
Review Comment:
Note that `createClient` failures of executor startup will not result in
task fail. The executor will fail after max io retries, and then the app
attempt will fail appMaster after the max number of executor failures is
reached, and there are still many app attempts waiting for us to retry. It
could be hours before you notice the app fail without the driver log telling
what mistake we've made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
