mridulm commented on code in PR #41785:
URL: https://github.com/apache/spark/pull/41785#discussion_r1252501967
##########
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java:
##########
@@ -245,12 +245,13 @@ TransportClient createClient(InetSocketAddress address)
logger.debug("Creating new connection to {}", address);
Bootstrap bootstrap = new Bootstrap();
+ int connCreateTimeout = conf.connectionCreationTimeoutMs();
Review Comment:
@yaooqinn we have discussed this quite a bit already and now going in
circles :-)
Essentially my point is this - instead of rejecting invalid configurations,
we are trying to workaround invalid user configs. Once released, this will be a
pattern we have to then continue supporting - I am not seeing a good reason why
we have to introduce this new behavior.
I would recommend simply rejecting the invalid config with an
`IllegalArgumentException` (we do this in a bunch of other places as well for
invalid user config), instead of introducing behavior which tries to workaround
it [1]: as long as the user gets to see the exception, they can fix the issue
and mitigate it.
Thoughts ?
+CC @dongjoon-hyun as well, since you reviewed the PR.
[1] If there is utility in introducing this, and not as a workaround for
user config, that would be interesting to know more about - it is not coming
out from the discussion here or in the jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
