lucyyao-db commented on code in PR #41705:
URL: https://github.com/apache/spark/pull/41705#discussion_r1253628016
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -133,6 +133,48 @@
"Could not load Protobuf class with name <protobufClassName>.
<explanation>."
]
},
+ "CANNOT_LOAD_STATE_STORE" : {
+ "message" : [
+ "An error occurred during loading state."
+ ],
+ "subClass" : {
+ "CANNOT_READ_CHECKPOINT" : {
+ "message" : [
+ "Cannot read RocksDB checkpoint metadata of version <versionLine>"
+ ]
+ },
+ "CANNOT_READ_DELTA_FILE" : {
+ "message" : [
+ "Error reading delta file <fileToRead> of <clazz>: <message>"
+ ]
+ },
+ "CANNOT_READ_SNAPSHOT_FILE" : {
+ "message" : [
+ "Error reading snapshot file <fileToRead> of <clazz>: <message>"
+ ]
+ },
+ "CANNOT_READ_STREAMING_STATE_FILE" : {
+ "message" : [
+ "Error reading streaming state file of <fileToRead> does not exist.
If the stream job is restarted with a new or updated state operation, please
create a new checkpoint location or clear the existing checkpoint location."
+ ]
+ },
+ "UNEXPECTED_FILE_SIZE" : {
+ "message" : [
+ "Copied <dfsFile> to <localFile>, expected <expectedSize> bytes,
found <localFileSize> bytes."
+ ]
+ },
+ "UNRELEASED_THREAD_ERROR": {
+ "message" : [
+ "<loggingId>: RocksDB instance could not be acquired by
<newAcquiredThreadInfo> as it was not released by <acquiredThreadInfo> after
<timeWaitedMs> ms.",
+ "Thread holding the lock has trace: <stackTraceOutput>"
+ ]
+ },
+ "WRAPPER" : {
+ "message" : [""]
Review Comment:
I think OTHER or UNKNOWN could be confusing since the error cause may be
known. WRAPPER is just a high-level error thrown that encompasses any error
thrown underneath it.
For example, throwing cannotReadDeltaFile or fileNotFoundException with
getStore/getReadStore as the entry point will then throw the WRAPPER error. We
can just throw cannotReadDeltaFile or fileNotFoundException and leave it as
that, but wrapping it with the WRAPPER error can give the user more context
that the error comes from loading state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
