lucyyao-db commented on code in PR #41705:
URL: https://github.com/apache/spark/pull/41705#discussion_r1264172205
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -123,12 +124,38 @@ class RocksDBSuite extends
AlsoTestWithChangelogCheckpointingEnabled with Shared
}
test("RocksDB: load version that doesn't exist") {
+ val provider = new RocksDBStateStoreProvider()
+ var ex = intercept[SparkException] {
+ provider.getStore(-1)
+ }
+ checkError(
+ ex,
+ errorClass = "CANNOT_LOAD_STATE_STORE.UNCATEGORIZED",
+ parameters = Map.empty
+ )
+ ex = intercept[SparkException] {
+ provider.getReadStore(-1)
+ }
+ checkError(
+ ex,
+ errorClass = "CANNOT_LOAD_STATE_STORE.UNCATEGORIZED",
+ parameters = Map.empty
+ )
+
val remoteDir = Utils.createTempDir().toString
new File(remoteDir).delete() // to make sure that the directory gets
created
withDB(remoteDir) { db =>
- intercept[IllegalStateException] {
+ ex = intercept[SparkException] {
db.load(1)
}
+ assert(ex.isInstanceOf[SparkException])
Review Comment:
forgot to remove this! will remove before merging
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -123,12 +124,38 @@ class RocksDBSuite extends
AlsoTestWithChangelogCheckpointingEnabled with Shared
}
test("RocksDB: load version that doesn't exist") {
+ val provider = new RocksDBStateStoreProvider()
+ var ex = intercept[SparkException] {
+ provider.getStore(-1)
+ }
+ checkError(
+ ex,
+ errorClass = "CANNOT_LOAD_STATE_STORE.UNCATEGORIZED",
+ parameters = Map.empty
+ )
+ ex = intercept[SparkException] {
+ provider.getReadStore(-1)
+ }
+ checkError(
+ ex,
+ errorClass = "CANNOT_LOAD_STATE_STORE.UNCATEGORIZED",
+ parameters = Map.empty
+ )
+
val remoteDir = Utils.createTempDir().toString
new File(remoteDir).delete() // to make sure that the directory gets
created
withDB(remoteDir) { db =>
- intercept[IllegalStateException] {
+ ex = intercept[SparkException] {
db.load(1)
}
+ assert(ex.isInstanceOf[SparkException])
Review Comment:
forgot to remove this! will remove before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
