lucyyao-db commented on code in PR #41705:
URL: https://github.com/apache/spark/pull/41705#discussion_r1261582385
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -720,9 +742,12 @@ class RocksDBSuite extends
AlsoTestWithChangelogCheckpointingEnabled with Shared
// Another thread should not be able to load while current thread is
using it
db.load(2)
- intercept[IllegalStateException] {
+ ex = intercept[SparkException] {
ThreadUtils.runInNewThread("concurrent-test-thread-2") { db.load(2) }
}
+ // Assert that the error message contains the stack trace
+ assert(ex.getMessage.contains("Thread holding the lock has trace:"))
+ assert(ex.getMessage.contains("runInNewThread"))
Review Comment:
I'm not sure how to validate the error thrown for unreleasedThreadError
given the parameters are <loggingId>, <newAcquiredThreadInfo>,
<acquiredThreadInfo>, <timeWaitedMs>, and <stackTraceOutput>. Perhaps this
error shouldn't be migrated to the new error framework at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
