LuciferYang commented on code in PR #42236:
URL: https://github.com/apache/spark/pull/42236#discussion_r1280118522
##########
connector/connect/server/src/test/java/org/apache/spark/sql/protobuf/protos/TestProto.java:
##########
@@ -0,0 +1,57 @@
+// Generated by the protocol buffer compiler. DO NOT EDIT!
+// source: test.proto
+
+package org.apache.spark.sql.protobuf.protos;
+
+/**
+ * SPARK-43646: This is generated by the
`connector/connect/server/src/test/resources/test.proto`
+ * to test the spark protobuf uber jar. If you need to regenerate this file:
+ * 1. Modify `connector/connect/server/src/test/resources/test.proto` to
generate Java files
+ * and replace the current file.
+ * 2. Replace all `com.google.protobuf` in the file with
`org.sparkproject.spark_protobuf.protobuf.`
+ * * <p>
+ * * TODO(SPARK-44606): Generate this file and replace the package names in
the file when testing.
+ */
+public final class TestProto {
Review Comment:
The task of generating Java files during testing and replacing all instances
of `com.google.protobuf.` with `org.sparkproject.spark_protobuf.protobuf.` in
the file will be carried forward as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
