pan3793 commented on PR #42236: URL: https://github.com/apache/spark/pull/42236#issuecomment-1665167038
Agree with @LuciferYang's opinion, better to use vanilla protobuf here. Generally, the relocation technically should be used carefully, and should not affect user API. Some users may look for examples from test cases, it should be consistent with the end users' code. (if someone copies code snippets from test code but can not run with their own project, really a bad experience) Historically, Hadoop and ORC have transitive protobuf 2.5 deps, which may cause deps conflict without shading and relocation in Spark, but it's not an issue today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
