LuciferYang commented on code in PR #42236: URL: https://github.com/apache/spark/pull/42236#discussion_r1283844577
########## connector/connect/server/src/test/resources/test.proto: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +syntax = "proto3"; + +package org.apache.spark.sql.protobuf.protos; + +option java_multiple_files = true; +option java_outer_classname = "TestProto"; + +message TestProtoObj { Review Comment: https://github.com/apache/spark/pull/42236#discussion_r1280118522 Thanks for your review, I have put the relevant explanation and TODO into the generated Java files. ``` /** * SPARK-43646: This is generated by the `connector/connect/server/src/test/resources/test.proto` * to test the spark protobuf uber jar. If you need to regenerate this file: * 1. Modify `connector/connect/server/src/test/resources/test.proto` to generate Java files * and replace the current file. * 2. Replace all `com.google.protobuf` in the file with `org.sparkproject.spark_protobuf.protobuf.` * * <p> * * TODO(SPARK-44606): Generate this file and replace the package names in the file when testing. */ ``` In addition to generating Java files from proto, the content of the generated files also needs path replacement. I haven't figured out how to automate this task yet, so I have left it as a TODO. For this TODO, I have added both the proto files and the generated Java files in the current PR. The generated Java files are the ones to be used currently, and the proto files are to be used for the TODO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
