cloud-fan commented on code in PR #40474:
URL: https://github.com/apache/spark/pull/40474#discussion_r1285367627
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1710,7 +1722,8 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
val resolvedNoOuter =
partitionExprs.map(resolveExpressionByPlanChildren(_, r))
val (newPartitionExprs, newChild) =
resolveExprsAndAddMissingAttrs(resolvedNoOuter, child)
// Outer reference has lower priority than this. See the doc of
`ResolveReferences`.
- val finalPartitionExprs = newPartitionExprs.map(resolveOuterRef)
+ val resolvedWithOuterRefs = newPartitionExprs.map(resolveOuterRef)
Review Comment:
```suggestion
val resolvedWithOuter = newPartitionExprs.map(resolveOuterRef)
```
to match the existing naming style in this rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
