cloud-fan commented on code in PR #40474:
URL: https://github.com/apache/spark/pull/40474#discussion_r1285368915


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveColumnDefaultInInsert.scala:
##########
@@ -40,7 +42,11 @@ import org.apache.spark.sql.types.StructField
  * 3. The plan nodes between [[UnresolvedInlineTable]] and 
[[InsertIntoStatement]] are either
  *    [[Project]], or [[Aggregate]], or [[SubqueryAlias]].
  */
-case object ResolveColumnDefaultInInsert extends SQLConfHelper with 
ColumnResolutionHelper {
+class ResolveColumnDefaultInInsert(catalog: SessionCatalog)

Review Comment:
   shall we rename it to `ResolveColumnDefaultInCommandInputQuery`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to