cloud-fan commented on code in PR #40474:
URL: https://github.com/apache/spark/pull/40474#discussion_r1285367745
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1725,7 +1738,8 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
val resolvedWithAgg = resolveColWithAgg(resolvedNoOuter, child)
val (newCond, newChild) =
resolveExprsAndAddMissingAttrs(Seq(resolvedWithAgg), child)
// Outer reference has lowermost priority. See the doc of
`ResolveReferences`.
- val finalCond = resolveOuterRef(newCond.head)
+ val withOuterCond = resolveOuterRef(newCond.head)
Review Comment:
```suggestion
val resolvedWithOuter = resolveOuterRef(newCond.head)
```
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
