sunchao commented on code in PR #42194:
URL: https://github.com/apache/spark/pull/42194#discussion_r1288959693
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala:
##########
@@ -299,6 +301,12 @@ object ShuffleExchangeExec {
ascending = true,
samplePointsPerPartitionHint =
SQLConf.get.rangeExchangeSampleSizePerPartition)
case SinglePartition => new ConstantPartitioner
+ case KeyGroupedPartitioning(expressions, n, partitionValues) =>
Review Comment:
It'd be great if we can also add a few tests in `EnsureRequirementsSuite` to
check that Spark picks the right side to shuffle when one side of a join is
non-key grouped partitioning and the other side is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
