sunchao commented on code in PR #42194:
URL: https://github.com/apache/spark/pull/42194#discussion_r1302282211
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -182,7 +182,16 @@ case class BatchScanExec(
// Now fill missing partition keys with empty partitions
val partitionMapping = nestGroupedPartitions.toMap
- finalPartitions = spjParams.commonPartitionValues.get.flatMap {
+
+ // SPARK-41471: We keep to order of partition keys in
`commonPartitionValues` to
Review Comment:
I think partition values should be sorted by themselves but just
`mergePartitions` in `EnsureRequirements` doesn't maintain the ordering.
Instead of doing it here, can we update
`InternalRowComparableWrapper.mergePartitions` to make sure the result is
ordered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
