sunchao commented on code in PR #42194:
URL: https://github.com/apache/spark/pull/42194#discussion_r1303195471
##########
core/src/main/scala/org/apache/spark/Partitioner.scala:
##########
@@ -137,6 +137,21 @@ private[spark] class PartitionIdPassthrough(override val
numPartitions: Int) ext
override def getPartition(key: Any): Int = key.asInstanceOf[Int]
}
+/**
+ * A [[org.apache.spark.Partitioner]] that partitions all records use
partition value map.
+ * The valueMap is a map that contains tuples of (partition value, partition
id). It generated
Review Comment:
nit:
- The `valueMap` (back-quoted to make it monospaced)
- "It generated" -> "It is generated"
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/exchange/EnsureRequirementsSuite.scala:
##########
@@ -1109,6 +1111,32 @@ class EnsureRequirementsSuite extends SharedSparkSession
{
}
}
+ test(s"SPARK-41471: shuffle right side when" +
Review Comment:
nit: there is no need to use `s` here, same for the line below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
