juliuszsompolski commented on PR #42441: URL: https://github.com/apache/spark/pull/42441#issuecomment-1675035785
Thanks @LuciferYang for the suggestions. This was a quick-and-dirty hack yesterday to see if I can get it working at all. I don't know much about the build system, so all the pointers about what can be removed as not relevant to the spinned out module are very helpful. What I would preferably want to do, is to not have to refactor this module out. It would be great if I could take the whole `connect-client-jvm` module, and include it as a testing dependency in `connect`, relocated so that it doesn't conflict with the server classes. And then could refer to `shaded.org.apache.spark.sql.connect.client.SparkConnectClient` in my testing code. I am investigating now if something like that is possible, either to define it in the `connect-client-jvm` module to export such relocated artifacts next to regular artifacts, or in the `connect` module, to relocate it when importing. Any pointers are also appreciated, as I don't know anything about the topic :-). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
