juliuszsompolski commented on PR #42441: URL: https://github.com/apache/spark/pull/42441#issuecomment-1675498338
This at least appears to work, but would need a lot of cleanup: * make the pom.xml of the spark-connect-client-jvm-internal and spark-connect-client-jvm, and the configuration objects for SparkConnectClient and SparkConnectClientInternal SparkBuild.scala actually reflect what each of these modules needs and remove the duplication of things copied over * move tests for org.apache.spark.connect.client to the jvm-internal module as well... @vicennial you set this up originally in https://github.com/apache/spark/pull/39078. Do you remember the context of which dependencies and which configs are needed for which parts, and could help separate the two? I would much rather have a simpler solution when I can just relocate it like in https://github.com/apache/spark/pull/42461, but I couldn't get that to work... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
