jdesjean commented on code in PR #42454:
URL: https://github.com/apache/spark/pull/42454#discussion_r1294075781
##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala:
##########
@@ -238,6 +244,79 @@ class SparkConnectServiceSuite extends SharedSparkSession
with MockitoSugar with
}
}
+ test("SPARK-44776: LocalTableScanExec") {
Review Comment:
Thank you for adding this test!
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteEventsManager.scala:
##########
@@ -193,12 +202,21 @@ case class ExecuteEventsManager(executeHolder:
ExecuteHolder, clock: Clock) {
/**
* Post @link
org.apache.spark.sql.connect.service.SparkListenerConnectOperationFinished.
*/
- def postFinished(): Unit = {
+ def postFinished(totalNumRowsOpt: Option[Long] = None): Unit = {
Review Comment:
Consider renaming to `producedRowsCountOpt`.
Please add documentation to indicate that this is the number of rows that
are returned to the user. None is expected when the command does not return any
rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
