jdesjean commented on code in PR #42454:
URL: https://github.com/apache/spark/pull/42454#discussion_r1300644469


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteEventsManager.scala:
##########
@@ -192,13 +201,23 @@ case class ExecuteEventsManager(executeHolder: 
ExecuteHolder, clock: Clock) {
 
   /**
    * Post @link 
org.apache.spark.sql.connect.service.SparkListenerConnectOperationFinished.
+   * @param producedRowsCountOpt
+   *   Number of rows that are returned to the user. None is expected when the 
operation does not

Review Comment:
   Agreed with [gjxdxh](https://github.com/gjxdxh) that it's clearer with None 
that no rows are expected for this operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to