jdesjean commented on code in PR #42454:
URL: https://github.com/apache/spark/pull/42454#discussion_r1294077945
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/SparkConnectPlanExecution.scala:
##########
@@ -163,7 +165,7 @@ private[execution] class
SparkConnectPlanExecution(executeHolder: ExecuteHolder)
// Collect errors and propagate them to the main thread.
.andThen {
case Success(_) =>
- executePlan.eventsManager.postFinished()
+ executePlan.eventsManager.postFinished(Some(totalNumRows))
Review Comment:
I see test failed
```
SPARK-41224: collect data using arrow *** FAILED *** (290 milliseconds)
[info] Some(50) did not equal Some(100)
(SparkConnectServiceSuite.scala:905)
[info] Analysis:
[info] Some(value: 50 -> 100)
```
We might have to move this `postFinished` after `ThreadUtils.awayReady`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
