cloud-fan commented on code in PR #42864:
URL: https://github.com/apache/spark/pull/42864#discussion_r1328218485
##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -414,12 +407,13 @@ object functions {
* @group agg_funcs
* @since 1.3.0
*/
- def count(e: Column): Column = withAggregateFunction {
- e.expr match {
+ def count(e: Column): Column = {
+ val withoutStar = e.expr match {
// Turn count(*) into count(1)
Review Comment:
Unrelated issue: this is not the right place to do this conversion. should
be done in the analyzer. cc @zhengruifeng does spark connect hit the same issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
