cloud-fan commented on code in PR #42864:
URL: https://github.com/apache/spark/pull/42864#discussion_r1328220027
##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -6843,9 +6562,8 @@ object functions {
* @since 3.0.0
*/
// scalastyle:on line.size.limit
- def schema_of_json(json: Column, options: java.util.Map[String, String]):
Column = {
- withExpr(SchemaOfJson(json.expr, options.asScala.toMap))
- }
+ def schema_of_json(json: Column, options: java.util.Map[String, String]):
Column =
Review Comment:
I think these should be the few exceptions that we should still keep them as
they were, because the expression (`SchemaOfJson` in this case) takes
non-expression inputs, and it's tricky to define a protocol that can pass
non-expression inputs as expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
