cloud-fan commented on code in PR #42864:
URL: https://github.com/apache/spark/pull/42864#discussion_r1331079422
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala:
##########
@@ -442,6 +442,10 @@ case class InSubquery(values: Seq[Expression], query:
ListQuery)
// scalastyle:on line.size.limit
case class In(value: Expression, list: Seq[Expression]) extends Predicate {
+ def this(valueAndList: Seq[Expression]) = {
Review Comment:
I'm not sure if this is useful. `in(a, b, c)` looks pretty weird to me. Can
we revert it and treat `def in` as a special case? The SQL parser also treat
`IN` as a special case and has dedicated syntax for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
