cloud-fan commented on code in PR #43155:
URL: https://github.com/apache/spark/pull/43155#discussion_r1339488349
##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -1067,7 +1067,11 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
// Compares proto plan with LogicalPlan.
private def comparePlans(connectPlan: proto.Relation, sparkPlan:
LogicalPlan): Unit = {
+ def normalizeDataframeId(plan: LogicalPlan): LogicalPlan = plan match {
Review Comment:
shall we use transform? why only top-level `CollectMetrics`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
