amaliujia commented on PR #43155: URL: https://github.com/apache/spark/pull/43155#issuecomment-1739514235
LGTM Another way to fix is manually construct the CollectMetrics to compare with the proto generated version. But this PR's approach is fine too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
