LuciferYang commented on PR #43155: URL: https://github.com/apache/spark/pull/43155#issuecomment-1746224877
> In `PlanGenerationTestSuite`, the `planId` was reset before each test > > https://github.com/apache/spark/blob/4863dec91f1cd596e60b42f1cbef9f6df327e562/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala#L119-L121 > > IIRC, the `dataframeId` in `CollectMetrics` is also the `planId`, so is it possible to simply reset the `planId` before problematic test suites? No, maybe it's not feasible. It's not just a matter of planId here. If we follow your argument, we would also need to add a new function for xx to reset `Dataset#curId`. https://github.com/apache/spark/blob/97597ba52842c6fcda5db27171439f9c02c1a782/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L70 https://github.com/apache/spark/blob/97597ba52842c6fcda5db27171439f9c02c1a782/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L204 https://github.com/apache/spark/blob/97597ba52842c6fcda5db27171439f9c02c1a782/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L2219-L2222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
