srowen commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1368659888
##########
sql/api/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##########
@@ -681,8 +681,6 @@ object Decimal {
override def toLong(x: Decimal): Long = x.toLong
override def fromInt(x: Int): Decimal = new Decimal().set(x)
override def compare(x: Decimal, y: Decimal): Int = x.compare(y)
- // Added from Scala 2.13; don't override to work in 2.12
- // TODO revisit once Scala 2.12 support is dropped
def parseString(str: String): Option[Decimal] = Try(Decimal(str)).toOption
Review Comment:
Right, so shouldn't it be a `override` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
