laglangyue commented on PR #43456: URL: https://github.com/apache/spark/pull/43456#issuecomment-1782342252
> > @amaliujia cc. shoudl `asIntegral` be removed for PhysicalFractionalType, float and double , I find the method not be used. if shoudle not removed,should we add this. `implicit object DoubleIsFractional extends DoubleIsFractional with Ordering.DoubleOrdering` because it is in scala2.12. thanks. > > We keep the methods for the completeness, even though they may not be used. So for the completeness we should keep those. Get it , I have roll back. By the way，do we need to redesign the double float based on `scala. path. Numeric. BigDecimalIsConflicted` in scala 2.13?It just seems like a slight difference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
