Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31048074
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size, ii, vv)
}
}
+
+ override def argmax: Int = {
+ if (size == 0) {
+ -1
+ } else {
+
+ var maxIdx = 0
+ var maxValue = if(indices(0) != 0) 0.0 else values(0)
+
+ foreachActive { (i, v) =>
+ if (v > maxValue) {
+ maxIdx = i
+ maxValue = v
+ }
+ }
+
+ // look for inactive values incase all active node values are
negative
+ if(size != values.size && maxValue < 0){
+ maxIdx = calcInactiveIdx(indices(0))
+ maxValue = 0
--- End diff --
I more kept it in there for clarity incase anyone is debugging through the
code and can more easily understand what the associated idx and val are. But i
can remove if its just too much clutter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
