dongjoon-hyun commented on code in PR #43643:
URL: https://github.com/apache/spark/pull/43643#discussion_r1381189549
##########
core/src/main/scala/org/apache/spark/deploy/master/ui/ApplicationPage.scala:
##########
@@ -98,6 +98,11 @@ private[ui] class ApplicationPage(parent: MasterWebUI)
extends WebUIPage("app")
<a href={UIUtils.makeHref(parent.master.reverseProxy,
app.id, app.desc.appUiUrl)}>Application Detail UI</a>
</strong></li>
+ } else if (parent.master.historyServerUrl.nonEmpty) {
+ <li><strong>
+ <a
href={s"${parent.master.historyServerUrl.get}/history/${app.id}"}>
Review Comment:
Thank you for review, @yaooqinn .
That's the reason why this is described as the best effort approach which
depends on the user's setting.
However, technically, your suggestion is not true, @yaooqinn , because SHS
is orthogonal from apps too. For example, app knows only `spark.eventLog.dir`,
not SHS info. In addition, you can launch multiple SHS based on the same event
location. Lastly, SHS can be behind proxy too. So, only the users know the
exposed SHS URL.
> So, IMO, we shall get the history server from the app itself instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
