yaooqinn commented on code in PR #43643:
URL: https://github.com/apache/spark/pull/43643#discussion_r1381201021
##########
core/src/main/scala/org/apache/spark/deploy/master/ui/ApplicationPage.scala:
##########
@@ -98,6 +98,11 @@ private[ui] class ApplicationPage(parent: MasterWebUI)
extends WebUIPage("app")
<a href={UIUtils.makeHref(parent.master.reverseProxy,
app.id, app.desc.appUiUrl)}>Application Detail UI</a>
</strong></li>
+ } else if (parent.master.historyServerUrl.nonEmpty) {
+ <li><strong>
+ <a
href={s"${parent.master.historyServerUrl.get}/history/${app.id}"}>
Review Comment:
If the user sets a different value for `spark.eventLog.dir` from the default
value
which `spark.ui.historyServerUrl` points to, he/she might get confused
while not able to find their apps.
Setting `spark.eventLog.dir/spark.ui.historyServerUrl` in pairs is
practical, for example,
- A user wants to keep its runtime data private
- The public history server is frequently overloaded, so they require a
custom one with improved UX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
